chore: stop supporting legacy console.sol signatures #8910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
added
the
T-likely-breaking
DaniPopes
force-pushed
the
dani/drop-legacy-hhconsole
branch
from
7d72887 to
d8bd045
Compare
DaniPopes
force-pushed
the
dani/drop-legacy-hhconsole
branch
2 times, most recently
from
ae51552 to
13b5605
Compare
DaniPopes
force-pushed
the
dani/drop-legacy-hhconsole
branch
from
13b5605 to
8018914
Compare
DaniPopes
force-pushed
the
dani/drop-legacy-hhconsole
branch
from
8018914 to
34cec8a
Compare
14 tasks
grandizzy
requested review from
grandizzy,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
zerosnacks
reviewed
Jan 9, 2025
zerosnacks
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See NomicFoundation/hardhat#5764, foundry-rs/forge-std#606.
Should probably wait a bit after foundry-rs/forge-std#606 is merged, since current forge-std console.sol would just stop working.Unblocked, ready for review